Commit ecda255e authored by Sam Bobroff's avatar Sam Bobroff Committed by David Gibson
Browse files

spapr: Correct reference count on spapr-cpu-core 



spapr_init_cpus() currently creates spapr-cpu-core objects via
object_new() and setting their realized property to true. This leaves
their reference count at two, because object_new() adds an initial
reference and the realization attaches them to a default parent object
which also increments the reference count.

This causes a problem if one of these cores is hot unplugged: no
delete event is generated for it because it's reference count doesn't
reach zero when it is detached from it's parent.

Correct this by adding a call to object_unref() in spapr_init_cpus().

Signed-off-by: default avatarSam Bobroff <sbobroff@linux.ibm.com>
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
parent 5d19be6c

hw/ppc/spapr.c

+2 −0
Original line number Diff line number Diff line
@@ -2480,6 +2480,8 @@ static void spapr_init_cpus(sPAPRMachineState *spapr) 
            object_property_set_int(core, core_id, CPU_CORE_PROP_CORE_ID,

                                    &error_fatal);

            object_property_set_bool(core, true, "realized", &error_fatal);



            object_unref(core);

        }

    }

}