Commit eca7a8e6 authored by Richard Henderson's avatar Richard Henderson Committed by Alex Bennée
Browse files

configure: Add -Werror to PIE probe 



Without -Werror, the probe may succeed, but then compilation fails
later when -Werror is added for other reasons.  Shows up on windows,
where the compiler complains about -fPIC.

Signed-off-by: default avatarRichard Henderson <richard.henderson@linaro.org>
Signed-off-by: default avatarAlex Bennée <alex.bennee@linaro.org>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200401214756.6559-1-richard.henderson@linaro.org>
Message-Id: <20200403191150.863-13-alex.bennee@linaro.org>
parent 58d5e749

configure

+2 −2
Original line number Diff line number Diff line
@@ -2119,7 +2119,7 @@ if compile_prog "-Werror -fno-pie" "-no-pie"; then 
fi



if test "$static" = "yes"; then

  if test "$pie" != "no" && compile_prog "-fPIE -DPIE" "-static-pie"; then

  if test "$pie" != "no" && compile_prog "-Werror -fPIE -DPIE" "-static-pie"; then

    QEMU_CFLAGS="-fPIE -DPIE $QEMU_CFLAGS"

    QEMU_LDFLAGS="-static-pie $QEMU_LDFLAGS"

    pie="yes"
@@ -2132,7 +2132,7 @@ if test "$static" = "yes"; then 
elif test "$pie" = "no"; then

  QEMU_CFLAGS="$CFLAGS_NOPIE $QEMU_CFLAGS"

  QEMU_LDFLAGS="$LDFLAGS_NOPIE $QEMU_LDFLAGS"

elif compile_prog "-fPIE -DPIE" "-pie"; then

elif compile_prog "-Werror -fPIE -DPIE" "-pie"; then

  QEMU_CFLAGS="-fPIE -DPIE $QEMU_CFLAGS"

  QEMU_LDFLAGS="-pie $QEMU_LDFLAGS"

  pie="yes"