Commit ebc184be authored by Benjamin Herrenschmidt's avatar Benjamin Herrenschmidt Committed by David Gibson
Browse files

ppc/xics/spapr: Fix H_IPOLL implementation 



H_IPOLL takes the CPU# of the processor to poll as an argument,
it doesn't operate on self.

Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: default avatarCédric Le Goater <clg@kaod.org>
Message-Id: <20190314063855.27890-1-clg@kaod.org>
Reviewed-by: default avatarGreg Kurz <groug@kaod.org>
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
parent f3e971ac

hw/intc/xics_spapr.c

+8 −1
Original line number Diff line number Diff line
@@ -95,8 +95,15 @@ static target_ulong h_eoi(PowerPCCPU *cpu, SpaprMachineState *spapr, 
static target_ulong h_ipoll(PowerPCCPU *cpu, SpaprMachineState *spapr,

                            target_ulong opcode, target_ulong *args)

{

    ICPState *icp = xics_icp_get(XICS_FABRIC(spapr), args[0]);

    uint32_t mfrr;

    uint32_t xirr = icp_ipoll(spapr_cpu_state(cpu)->icp, &mfrr);

    uint32_t xirr;



    if (!icp) {

        return H_PARAMETER;

    }



    xirr = icp_ipoll(icp, &mfrr);



    args[0] = xirr;

    args[1] = mfrr;