Commit ead75d84 authored by Philippe Mathieu-Daudé's avatar Philippe Mathieu-Daudé Committed by Paolo Bonzini
Browse files

gdbstub: Prevent fd leakage 



Since 2f652224, we now check if socket_set_nodelay() errored,
but forgot to close the socket before reporting an error.

Fixes: Coverity CID 1391290 (RESOURCE_LEAK)
Signed-off-by: default avatarPhilippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20180524223458.5651-1-f4bug@amsat.org>
Reviewed-by: default avatarThomas Huth <thuth@redhat.com>
Reviewed-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 3a0adfc9

gdbstub.c

+1 −0
Original line number Diff line number Diff line
@@ -1842,6 +1842,7 @@ static bool gdb_accept(void) 
    /* set short latency */

    if (socket_set_nodelay(fd)) {

        perror("setsockopt");

        close(fd);

        return false;

    }