Commit ea204dda authored by Daniel P. Berrangé's avatar Daniel P. Berrangé Committed by Max Reitz
Browse files

qemu-img: fix --image-opts usage with dd command 



The --image-opts flag can only be used to affect the parsing
of the source image. The target image has to be specified in
the traditional style regardless, since it needs to be passed
to the bdrv_create() API which does not support the new style
opts.

Reviewed-by: default avatarFam Zheng <famz@redhat.com>
Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
Signed-off-by: default avatarDaniel P. Berrange <berrange@redhat.com>
Message-id: 20170515164712.6643-3-berrange@redhat.com
Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
parent 83d4bf94

qemu-img.c

+7 −2
Original line number Diff line number Diff line
@@ -4316,7 +4316,12 @@ static int img_dd(int argc, char **argv) 
        goto out;

    }



    blk2 = img_open(image_opts, out.filename, out_fmt, BDRV_O_RDWR,

    /* TODO, we can't honour --image-opts for the target,

     * since it needs to be given in a format compatible

     * with the bdrv_create() call above which does not

     * support image-opts style.

     */

    blk2 = img_open_file(out.filename, out_fmt, BDRV_O_RDWR,

                         false, false, false);



    if (!blk2) {