Commit e94f0687 authored by Gerd Hoffmann's avatar Gerd Hoffmann Committed by Alex Bennée
Browse files

Revert "vga: build virtio-gpu as module" 



This reverts commit 8d5a24c8.

Compiling all virtio-gpu objects into a single module isn't a good plan
because the individual objects have different CONFIG_* dependencies.
Leads to module load failures on s390x due to vga support being
disabled, which in turn breaks '-device virtio-gpu-device' (flagged by
travis ci).

So back to the drawing board for modular virtio-gpu ...

Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
Signed-off-by: default avatarAlex Bennée <alex.bennee@linaro.org>
Message-Id: <20200710203652.9708-3-kraxel@redhat.com>
parent 024ce1ef

hw/display/Makefile.objs

+10 −13
Original line number Diff line number Diff line
@@ -49,19 +49,16 @@ common-obj-m += qxl.mo 
qxl.mo-objs = qxl.o qxl-logger.o qxl-render.o

endif



ifeq ($(CONFIG_VIRTIO_GPU),y)

common-obj-m += virtio-gpu.mo

virtio-gpu-obj-$(CONFIG_VIRTIO_GPU) += virtio-gpu-base.o virtio-gpu.o virtio-gpu-3d.o

virtio-gpu-obj-$(CONFIG_VHOST_USER_GPU) += vhost-user-gpu.o

virtio-gpu-obj-$(call land,$(CONFIG_VIRTIO_GPU),$(CONFIG_VIRTIO_PCI)) += virtio-gpu-pci.o

virtio-gpu-obj-$(call land,$(CONFIG_VHOST_USER_GPU),$(CONFIG_VIRTIO_PCI)) += vhost-user-gpu-pci.o

virtio-gpu-obj-$(CONFIG_VIRTIO_VGA) += virtio-vga.o

virtio-gpu-obj-$(CONFIG_VHOST_USER_VGA) += vhost-user-vga.o

virtio-gpu.mo-objs := $(virtio-gpu-obj-y)

virtio-gpu.mo-cflags := $(VIRGL_CFLAGS)

virtio-gpu.mo-libs := $(VIRGL_LIBS)

endif



common-obj-$(CONFIG_VIRTIO_GPU) += virtio-gpu-base.o virtio-gpu.o virtio-gpu-3d.o

common-obj-$(CONFIG_VHOST_USER_GPU) += vhost-user-gpu.o

common-obj-$(call land,$(CONFIG_VIRTIO_GPU),$(CONFIG_VIRTIO_PCI)) += virtio-gpu-pci.o

common-obj-$(call land,$(CONFIG_VHOST_USER_GPU),$(CONFIG_VIRTIO_PCI)) += vhost-user-gpu-pci.o

common-obj-$(CONFIG_VIRTIO_VGA) += virtio-vga.o

common-obj-$(CONFIG_VHOST_USER_VGA) += vhost-user-vga.o

virtio-gpu.o-cflags := $(VIRGL_CFLAGS)

virtio-gpu.o-libs += $(VIRGL_LIBS)

virtio-gpu-3d.o-cflags := $(VIRGL_CFLAGS)

virtio-gpu-3d.o-libs += $(VIRGL_LIBS)

common-obj-$(CONFIG_DPCD) += dpcd.o

common-obj-$(CONFIG_XLNX_ZYNQMP_ARM) += xlnx_dp.o

util/module.c

+0 −6
Original line number Diff line number Diff line
@@ -266,12 +266,6 @@ static struct { 
    { "usb-redir",             "hw-", "usb-redirect"          },

    { "qxl-vga",               "hw-", "display-qxl"           },

    { "qxl",                   "hw-", "display-qxl"           },

    { "virtio-gpu-device",     "hw-", "display-virtio-gpu"    },

    { "virtio-gpu-pci",        "hw-", "display-virtio-gpu"    },

    { "virtio-vga",            "hw-", "display-virtio-gpu"    },

    { "vhost-user-gpu-device", "hw-", "display-virtio-gpu"    },

    { "vhost-user-gpu-pci",    "hw-", "display-virtio-gpu"    },

    { "vhost-user-vga",        "hw-", "display-virtio-gpu"    },

    { "chardev-braille",       "chardev-", "baum"             },

};