Commit e81e7b52 authored by Thomas Huth's avatar Thomas Huth
Browse files

seccomp: Work-around GCC 4.x bug in gnu99 mode 

We'd like to compile QEMU with -std=gnu99, but GCC 4.8 currently
fails to compile qemu-seccomp.c in this mode:

qemu-seccomp.c:45:1: error: initializer element is not constant
 };
 ^
qemu-seccomp.c:45:1: error: (near initialization for ‘sched_setscheduler_arg[0]’)

This is due to a compiler bug which has just been fixed in GCC 5.0:

 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63567



Since we still want to support GCC 4.8 for a while and also want to use
gnu99 mode, work-around the issue by expanding the macro manually.

Reviewed-by: default avatarDaniel P. Berrangé <berrange@redhat.com>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: default avatarEduardo Otubo <otubo@redhat.com>
Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
parent df71ca84

qemu-seccomp.c

+2 −1
Original line number Diff line number Diff line
@@ -41,7 +41,8 @@ struct QemuSeccompSyscall { 
};



const struct scmp_arg_cmp sched_setscheduler_arg[] = {

    SCMP_A1(SCMP_CMP_NE, SCHED_IDLE)

    /* was SCMP_A1(SCMP_CMP_NE, SCHED_IDLE), but expanded due to GCC 4.x bug */

    { .arg = 1, .op = SCMP_CMP_NE, .datum_a = SCHED_IDLE }

};



static const struct QemuSeccompSyscall blacklist[] = {