Commit e6e8db03 authored by Max Reitz's avatar Max Reitz
Browse files

iotests: Fix 125 for growth_mode = metadata 



If we use growth_mode = metadata, it is very much possible that the file
uses more disk space after we have written something to the added area.
We did indeed want to test for this case, but unfortunately we evidently
just copied the code from the "Test creation preallocation" section and
forgot to replace "$create_mode" by "$growth_mode".

We never noticed because we only read the first number from qemu-img
info's "disk size" output -- and that is effectively useless, because
qemu-img prints a human-readable value (which generally includes a
decimal point).  That will be fixed in the patch after the next one.

Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
Message-id: 20190925183231.11196-2-mreitz@redhat.com
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
parent d9245599

tests/qemu-iotests/125

+1 −1
Original line number Diff line number Diff line
@@ -111,7 +111,7 @@ for GROWTH_SIZE in 16 48 80; do 
                if [ $file_length_2 -gt $file_length_1 ]; then

                    echo "ERROR (grow): Image length has grown from $file_length_1 to $file_length_2"

                fi

                if [ $create_mode != metadata ]; then

                if [ $growth_mode != metadata ]; then

                    # The host size should not have grown either

                    if [ $host_size_2 -gt $host_size_1 ]; then

                        echo "ERROR (grow): Host size has grown from $host_size_1 to $host_size_2"