Commit e6cc11d6 authored by yuchenlin's avatar yuchenlin Committed by Michael S. Tsirkin
Browse files

vhost-scsi: prevent using uninitialized vqs 



There are 3 virtqueues (ctrl, event and cmd) for virtio scsi device,
but seabios will only set the physical address for the 3rd one (cmd).
Then in vhost_virtqueue_start(), virtio_queue_get_desc_addr()
will be 0 for ctrl and event vq.

In this case, ctrl and event vq are not initialized.
vhost_verify_ring_mappings may use uninitialized vhost_virtqueue
such that vhost_verify_ring_part_mapping returns ENOMEM.

When encountered this problem, we got the following logs:

    qemu-system-x86_64: Unable to map available ring for ring 0
    qemu-system-x86_64: Verify ring failure on region 0

Signed-off-by: default avatarForrest Liu <forrestl@synology.com>
Signed-off-by: default avataryuchenlin <yuchenlin@synology.com>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent 9b178f0e

hw/scsi/vhost-scsi.c

+1 −1
Original line number Diff line number Diff line
@@ -183,7 +183,7 @@ static void vhost_scsi_realize(DeviceState *dev, Error **errp) 
    }



    vsc->dev.nvqs = VHOST_SCSI_VQ_NUM_FIXED + vs->conf.num_queues;

    vsc->dev.vqs = g_new(struct vhost_virtqueue, vsc->dev.nvqs);

    vsc->dev.vqs = g_new0(struct vhost_virtqueue, vsc->dev.nvqs);

    vsc->dev.vq_index = 0;

    vsc->dev.backend_features = 0;