Commit e67e91b4 authored by Philippe Mathieu-Daudé's avatar Philippe Mathieu-Daudé Committed by Laurent Vivier
Browse files

hw/input/tsc210x: Fix building with no verbosity 



When building with TSC_VERBOSE not defined, we get:
      CC      arm-softmmu/hw/input/tsc210x.o
    hw/input/tsc210x.c: In function ‘tsc2102_data_register_write’:
    hw/input/tsc210x.c:554:5: error: label at end of compound statement
         default:
         ^~~~~~~
    hw/input/tsc210x.c: In function ‘tsc2102_control_register_write’:
    hw/input/tsc210x.c:638:5: error: label at end of compound statement
         bad_reg:
         ^~~~~~~
    hw/input/tsc210x.c: In function ‘tsc2102_audio_register_write’:
    hw/input/tsc210x.c:766:5: error: label at end of compound statement
         default:
         ^~~~~~~
    make[1]: *** [rules.mak:69: hw/input/tsc210x.o] Error 1

Fix this by replacing the culprit fprintf(stderr) calls by a more
recent API: qemu_log_mask(LOG_GUEST_ERROR). Other fprintf() calls
are left untouched.

Signed-off-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: default avatarThomas Huth <thuth@redhat.com>
Reviewed-by: default avatarStefano Garzarella <sgarzare@redhat.com>
Message-Id: <20190204204517.23698-1-philmd@redhat.com>
Signed-off-by: default avatarLaurent Vivier <laurent@vivier.eu>
parent dab864dc

hw/input/tsc210x.c

+6 −12
Original line number Diff line number Diff line
@@ -552,10 +552,8 @@ static void tsc2102_data_register_write( 
        return;



    default:

#ifdef TSC_VERBOSE

        fprintf(stderr, "tsc2102_data_register_write: "

        qemu_log_mask(LOG_GUEST_ERROR, "tsc2102_data_register_write: "

                                       "no such register: 0x%02x\n", reg);

#endif

    }

}
@@ -636,10 +634,8 @@ static void tsc2102_control_register_write( 


    default:

    bad_reg:

#ifdef TSC_VERBOSE

        fprintf(stderr, "tsc2102_control_register_write: "

        qemu_log_mask(LOG_GUEST_ERROR, "tsc2102_control_register_write: "

                                       "no such register: 0x%02x\n", reg);

#endif

    }

}
@@ -764,10 +760,8 @@ static void tsc2102_audio_register_write( 
        return;



    default:

#ifdef TSC_VERBOSE

        fprintf(stderr, "tsc2102_audio_register_write: "

        qemu_log_mask(LOG_GUEST_ERROR, "tsc2102_audio_register_write: "

                                       "no such register: 0x%02x\n", reg);

#endif

    }

}