Commit e62694a0 authored by Peter Maydell's avatar Peter Maydell
Browse files

hw/char/exynos4210_uart: Drop unused local variable frame_size 

The frame_size local variable in exynos4210_uart_update_parameters()
is calculated but never used (and has been this way since the
device was introduced in commit e5a4914e). The qemu_chr_fe_ioctl()
doesn't need this information (if it really wanted it it could
calculate it from the parity/data_bits/stop_bits), so just drop
the variable entirely.

Fixes: https://bugs.launchpad.net/bugs/1655702



Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Message-id: 1484589515-26353-1-git-send-email-peter.maydell@linaro.org
parent d05a8628

hw/char/exynos4210_uart.c

+1 −5
Original line number Diff line number Diff line
@@ -306,7 +306,7 @@ static void exynos4210_uart_update_irq(Exynos4210UartState *s) 


static void exynos4210_uart_update_parameters(Exynos4210UartState *s)

{

    int speed, parity, data_bits, stop_bits, frame_size;

    int speed, parity, data_bits, stop_bits;

    QEMUSerialSetParams ssp;

    uint64_t uclk_rate;
@@ -314,9 +314,7 @@ static void exynos4210_uart_update_parameters(Exynos4210UartState *s) 
        return;

    }



    frame_size = 1; /* start bit */

    if (s->reg[I_(ULCON)] & 0x20) {

        frame_size++; /* parity bit */

        if (s->reg[I_(ULCON)] & 0x28) {

            parity = 'E';

        } else {
@@ -334,8 +332,6 @@ static void exynos4210_uart_update_parameters(Exynos4210UartState *s) 


    data_bits = (s->reg[I_(ULCON)] & 0x3) + 5;



    frame_size += data_bits + stop_bits;



    uclk_rate = 24000000;



    speed = uclk_rate / ((16 * (s->reg[I_(UBRDIV)]) & 0xffff) +