Commit e6144bf9 authored by Greg Kurz's avatar Greg Kurz Committed by David Gibson
Browse files

xics: Make some device types not user creatable 



Some device types of the XICS model are exposed to the QEMU command
line:

$ ppc64-softmmu/qemu-system-ppc64 -device help | grep ic[sp]
name "icp"
name "ics"
name "ics-spapr"
name "pnv-icp", desc "PowerNV ICP"

These are internal devices that shouldn't be instantiable by the
user. By the way, they can't be because their respective realize
functions expect link properties that can't be set from the command
line:

qemu-system-ppc64: -device icp: required link 'xics' not found:
 Property '.xics' not found
qemu-system-ppc64: -device ics: required link 'xics' not found:
 Property '.xics' not found
qemu-system-ppc64: -device ics-spapr: required link 'xics' not found:
 Property '.xics' not found
qemu-system-ppc64: -device pnv-icp: required link 'xics' not found:
 Property '.xics' not found

Hide them by setting dc->user_creatable to false in the base class
"icp" and "ics" init functions.

Signed-off-by: default avatarGreg Kurz <groug@kaod.org>
Message-Id: <157017826724.337875.14822177178282524024.stgit@bahia.lan>
Message-Id: <157045578962.865784.8551555523533955113.stgit@bahia.lan>
[dwg: Folded reason comment into base patch]
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
parent 878b2b48

hw/intc/xics.c

+10 −0
Original line number Diff line number Diff line
@@ -369,6 +369,11 @@ static void icp_class_init(ObjectClass *klass, void *data) 


    dc->realize = icp_realize;

    dc->unrealize = icp_unrealize;

    /*

     * Reason: part of XICS interrupt controller, needs to be wired up

     * by icp_create().

     */

    dc->user_creatable = false;

}



static const TypeInfo icp_info = {
@@ -689,6 +694,11 @@ static void ics_class_init(ObjectClass *klass, void *data) 
    dc->props = ics_properties;

    dc->reset = ics_reset;

    dc->vmsd = &vmstate_ics;

    /*

     * Reason: part of XICS interrupt controller, needs to be wired up,

     * e.g. by spapr_irq_init().

     */

    dc->user_creatable = false;

}



static const TypeInfo ics_info = {