Commit e60baebd authored by Gonglei's avatar Gonglei Committed by Gerd Hoffmann
Browse files

usb-mtp: fix segmentation fault 



When x-root property not be configured, will cause segfault
because of null pointer accessing. Add a check for s->root
property avoid segfault.

Signed-off-by: default avatarGonglei <arei.gonglei@huawei.com>
Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent 7c03a899

hw/usb/dev-mtp.c

+4 −0
Original line number Diff line number Diff line
@@ -1071,6 +1071,10 @@ static void usb_mtp_realize(USBDevice *dev, Error **errp) 
    usb_desc_init(dev);

    QTAILQ_INIT(&s->objects);

    if (s->desc == NULL) {

        if (s->root == NULL) {

            error_setg(errp, "usb-mtp: x-root property must be configured");

            return;

        }

        s->desc = strrchr(s->root, '/');

        if (s->desc && s->desc[0]) {

            s->desc = g_strdup(s->desc + 1);