Commit e5e62683 authored by Denis V. Lunev's avatar Denis V. Lunev Committed by Kevin Wolf
Browse files

parallels: drop check that bdrv_truncate() is working 



This would be actually strange and error prone. If truncate() nowadays
will fail, there is something fatally wrong. Let's check for that during
the actual work.

The only fallback case is when the file is not zero initialized. In this
case we should switch to preallocation via fallocate().

Signed-off-by: default avatarDenis V. Lunev <den@openvz.org>
CC: Markus Armbruster <armbru@redhat.com>
CC: Kevin Wolf <kwolf@redhat.com>
CC: Max Reitz <mreitz@redhat.com>
CC: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
parent d8b83e37

block/parallels.c

+1 −3
Original line number Diff line number Diff line
@@ -703,9 +703,7 @@ static int parallels_open(BlockDriverState *bs, QDict *options, int flags, 
        goto fail_options;

    }



    if (!(flags & BDRV_O_RESIZE) || !bdrv_has_zero_init(bs->file->bs) ||

            bdrv_truncate(bs->file, bdrv_getlength(bs->file->bs),

                          PREALLOC_MODE_OFF, NULL) != 0) {

    if (!bdrv_has_zero_init(bs->file->bs)) {

        s->prealloc_mode = PRL_PREALLOC_MODE_FALLOCATE;

    }