Commit e5bc201d authored by Glauber Costa's avatar Glauber Costa Committed by Anthony Liguori
Browse files

do proper cpu_self check 



Currently, our check for qemu_cpu_self only checks if there is a cpu
currently in execution (represented by cpu_single_env being set). While
this might be okay for tcg, it is certainly not okay for kvm, since multiple
cpus might be executing.

Instead, I propose we use pthread primitives to test if the caller thread is
the same as env->thread.

For tcg, it will have the same semantics as before, since all CPUStates will
point to the same thread, and we'll only have one in execution at a time.

Signed-off-by: default avatarGlauber Costa <glommer@mothafucka.localdomain>
Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
parent 47cbc7aa

vl.c

+7 −2
Original line number Diff line number Diff line
@@ -3591,9 +3591,14 @@ void qemu_cpu_kick(void *_env) 
        qemu_thread_signal(env->thread, SIGUSR1);

}



int qemu_cpu_self(void *env)

int qemu_cpu_self(void *_env)

{

    return (cpu_single_env != NULL);

    CPUState *env = _env;

    QemuThread this;

 

    qemu_thread_self(&this);

 

    return qemu_thread_equal(&this, env->thread);

}



static void cpu_signal(int sig)