Commit e4a511f8 authored by Paolo Bonzini's avatar Paolo Bonzini
Browse files

exec: clamp accesses against the MemoryRegionSection 



Because the clamping was done against the MemoryRegion,
address_space_rw was effectively broken if a write spanned
multiple sections that are not linear in underlying memory
(with the memory not being under an IOMMU).

This is visible with the MIPS rc4030 IOMMU, which is implemented
as a series of alias memory regions that point to the actual RAM.

Tested-by: default avatarHervé Poussineau <hpoussin@reactos.org>
Tested-by: default avatarMark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 965eb2fc

exec.c

+1 −1
Original line number Diff line number Diff line
@@ -353,7 +353,7 @@ address_space_translate_internal(AddressSpaceDispatch *d, hwaddr addr, hwaddr *x 


    mr = section->mr;

    if (memory_region_is_ram(mr)) {

        diff = int128_sub(mr->size, int128_make64(addr));

        diff = int128_sub(section->size, int128_make64(addr));

        *plen = int128_get64(int128_min(diff, int128_make64(*plen)));

    }

    return section;