Commit e446a1eb authored by Marc-André Lureau's avatar Marc-André Lureau Committed by Greg Kurz
Browse files

9p: v9fs_path_copy() readability 



lhs/rhs doesn't tell much about how argument are handled, dst/src is
and const arguments is clearer in my mind. Use g_memdup() while at it.

Signed-off-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: default avatarGreg Kurz <groug@kaod.org>
parent 299a2e6f

hw/9pfs/9p.c

+4 −5
Original line number Diff line number Diff line
@@ -190,12 +190,11 @@ v9fs_path_sprintf(V9fsPath *path, const char *fmt, ...) 
    va_end(ap);

}



void v9fs_path_copy(V9fsPath *lhs, V9fsPath *rhs)

void v9fs_path_copy(V9fsPath *dst, const V9fsPath *src)

{

    v9fs_path_free(lhs);

    lhs->data = g_malloc(rhs->size);

    memcpy(lhs->data, rhs->data, rhs->size);

    lhs->size = rhs->size;

    v9fs_path_free(dst);

    dst->size = src->size;

    dst->data = g_memdup(src->data, src->size);

}



int v9fs_name_to_path(V9fsState *s, V9fsPath *dirpath,

hw/9pfs/9p.h

+1 −1
Original line number Diff line number Diff line
@@ -343,7 +343,7 @@ void coroutine_fn v9fs_reclaim_fd(V9fsPDU *pdu); 
void v9fs_path_init(V9fsPath *path);

void v9fs_path_free(V9fsPath *path);

void v9fs_path_sprintf(V9fsPath *path, const char *fmt, ...);

void v9fs_path_copy(V9fsPath *lhs, V9fsPath *rhs);

void v9fs_path_copy(V9fsPath *dst, const V9fsPath *src);

int v9fs_name_to_path(V9fsState *s, V9fsPath *dirpath,

                      const char *name, V9fsPath *path);

int v9fs_device_realize_common(V9fsState *s, const V9fsTransport *t,