Commit e3bb532c authored by Hani Benhabiles's avatar Hani Benhabiles Committed by Luiz Capitulino
Browse files

monitor: Add host_net_add device argument completion 



Also fix the parameters documentation.

Signed-off-by: default avatarHani Benhabiles <hani@linux.com>
Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: default avatarLuiz Capitulino <lcapitulino@redhat.com>
parent 84007e81

hmp-commands.hx

+2 −1
Original line number Diff line number Diff line
@@ -1209,9 +1209,10 @@ ETEXI 
    {

        .name       = "host_net_add",

        .args_type  = "device:s,opts:s?",

        .params     = "tap|user|socket|vde|netmap|dump [options]",

        .params     = "tap|user|socket|vde|netmap|bridge|dump [options]",

        .help       = "add host VLAN client",

        .mhandler.cmd = net_host_device_add,

        .command_completion = host_net_add_completion,

    },



STEXI

hmp.h

+1 −0
Original line number Diff line number Diff line
@@ -109,5 +109,6 @@ void watchdog_action_completion(ReadLineState *rs, int nb_args, 
                                const char *str);

void migrate_set_capability_completion(ReadLineState *rs, int nb_args,

                                       const char *str);

void host_net_add_completion(ReadLineState *rs, int nb_args, const char *str);



#endif

monitor.c

+16 −0
Original line number Diff line number Diff line
@@ -4594,6 +4594,22 @@ void migrate_set_capability_completion(ReadLineState *rs, int nb_args, 
    }

}



void host_net_add_completion(ReadLineState *rs, int nb_args, const char *str)

{

    int i;

    size_t len;

    if (nb_args != 2) {

        return;

    }

    len = strlen(str);

    readline_set_completion_index(rs, len);

    for (i = 0; host_net_devices[i]; i++) {

        if (!strncmp(host_net_devices[i], str, len)) {

            readline_add_completion(rs, host_net_devices[i]);

        }

    }

}



static void monitor_find_completion_by_table(Monitor *mon,

                                             const mon_cmd_t *cmd_table,

                                             char **args,