Commit e2bcadad authored by Kevin Wolf's avatar Kevin Wolf
Browse files

ide: Handle flush failure 



Instead of always assuming success for bdrv_aio_flush, actually do something
with the error. This respects the werror option and accordingly ignores the
error, reports it to the guest or stops the VM and retries after cont.

Ignoring the error is trivial, obviously. For stopping the VM and retrying
later old code can be reused, but we need to introduce a new status for "retry
a flush". For reporting to the guest, fortunately the same action is required
as for a failed read/write (status = DRDY | ERR, error = ABRT), so this code
can be reused as well.

Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
parent 6bcb1a79

hw/ide/core.c

+9 −1
Original line number Diff line number Diff line
@@ -65,6 +65,7 @@ static void ide_dma_start(IDEState *s, BlockDriverCompletionFunc *dma_cb); 
static void ide_dma_restart(IDEState *s, int is_read);

static void ide_atapi_cmd_read_dma_cb(void *opaque, int ret);

static int ide_handle_rw_error(IDEState *s, int error, int op);

static void ide_flush_cache(IDEState *s);



static void padstr(char *str, const char *src, int len)

{
@@ -688,6 +689,8 @@ static void ide_dma_restart_bh(void *opaque) 
        } else {

            ide_sector_write(bmdma_active_if(bm));

        }

    } else if (bm->status & BM_STATUS_RETRY_FLUSH) {

        ide_flush_cache(bmdma_active_if(bm));

    }

}
@@ -795,7 +798,12 @@ static void ide_flush_cb(void *opaque, int ret) 
{

    IDEState *s = opaque;



    /* XXX: how do we signal I/O errors here? */

    if (ret < 0) {

        /* XXX: What sector number to set here? */

        if (ide_handle_rw_error(s, -ret, BM_STATUS_RETRY_FLUSH)) {

            return;

        }

    }



    s->status = READY_STAT | SEEK_STAT;

    ide_set_irq(s->bus);

hw/ide/internal.h

+2 −1
Original line number Diff line number Diff line
@@ -473,6 +473,7 @@ struct IDEDeviceInfo { 
#define BM_STATUS_DMA_RETRY  0x08

#define BM_STATUS_PIO_RETRY  0x10

#define BM_STATUS_RETRY_READ  0x20

#define BM_STATUS_RETRY_FLUSH 0x40



#define BM_CMD_START     0x01

#define BM_CMD_READ      0x08