Commit e02d9494 authored by Paul Durrant's avatar Paul Durrant Committed by Anthony PERARD
Browse files

dataplane/xen-block: remove dead code 



The if() statement is clearly bogus (dead code which should have been
cleaned up when grant mapping was removed).

Spotted by Coverity: CID 1398635

While in the neighbourhood, add a missing 'fall through' annotation.

Reported-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Signed-off-by: default avatarPaul Durrant <paul.durrant@citrix.com>
Acked-by: default avatarAnthony PERARD <anthony.perard@citrix.com>
Message-Id: <20190215162533.19475-2-paul.durrant@citrix.com>
Signed-off-by: default avatarAnthony PERARD <anthony.perard@citrix.com>
parent 711d13d5

hw/block/dataplane/xen-block.c

+1 −4
Original line number Diff line number Diff line
@@ -281,10 +281,6 @@ static void xen_block_complete_aio(void *opaque, int ret) 
        break;

    case BLKIF_OP_WRITE:

    case BLKIF_OP_FLUSH_DISKCACHE:

        if (!request->req.nr_segments) {

            break;

        }

        break;

    default:

        break;

    }
@@ -298,6 +294,7 @@ static void xen_block_complete_aio(void *opaque, int ret) 
        if (!request->req.nr_segments) {

            break;

        }

        /* fall through */

    case BLKIF_OP_READ:

        if (request->status == BLKIF_RSP_OKAY) {

            block_acct_done(blk_get_stats(dataplane->blk), &request->acct);