Commit dfe7053a authored by Don Slutz's avatar Don Slutz Committed by Blue Swirl
Browse files

CHECKPATCH: Add warning for single else statement. 



For an example:

WARNING: braces {} are necessary even for single statement blocks
+    } else
+        return env->regs[R_EAX];

total: 0 errors, 1 warnings, 41 lines checked
Signed-off-by: default avatarDon Slutz <Don@CloudSwitch.com>
Signed-off-by: default avatarBlue Swirl <blauwirbel@gmail.com>
parent 69402a69

scripts/checkpatch.pl

+10 −6
Original line number Diff line number Diff line
@@ -2549,10 +2549,14 @@ sub process { 


                        # Check the pre-context.

                        if (substr($line, 0, $-[0]) =~ /(\}\s*)$/) {

                            my $pre = $1;



                            if ($line !~ /else/) {

                                print "APW: ALLOWED: pre<$pre> line<$line>\n"

                                    if $dbg_adv_apw;

                                $allowed = 1;

                            }

                        }



			my ($level, $endln, @chunks) =

				ctx_statement_full($linenr, $realcnt, $-[0]);