Commit df4e0010 authored by Richard Henderson's avatar Richard Henderson Committed by Peter Maydell
Browse files

target/arm: Fix sign of sve_cmpeq_ppzw/sve_cmpne_ppzw 



The normal vector element is sign-extended before
comparing with the wide vector element.

Reported-by: default avatarLaurent Desnogues <laurent.desnogues@gmail.com>
Signed-off-by: default avatarRichard Henderson <richard.henderson@linaro.org>
Reviewed-by: default avatarLaurent Desnogues <laurent.desnogues@gmail.com>
Reviewed-by: default avatarAlex Bennée <alex.bennee@linaro.org>
Tested-by: default avatarAlex Bennée <alex.bennee@linaro.org>
Tested-by: default avatarLaurent Desnogues <laurent.desnogues@gmail.com>
Message-id: 20180801123111.3595-2-richard.henderson@linaro.org
Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
parent 5f62d3b9

target/arm/sve_helper.c

+6 −6
Original line number Diff line number Diff line
@@ -2436,13 +2436,13 @@ uint32_t HELPER(NAME)(void *vd, void *vn, void *vm, void *vg, uint32_t desc) \ 
#define DO_CMP_PPZW_S(NAME, TYPE, TYPEW, OP) \

    DO_CMP_PPZW(NAME, TYPE, TYPEW, OP, H1_4, 0x1111111111111111ull)



DO_CMP_PPZW_B(sve_cmpeq_ppzw_b, uint8_t,  uint64_t, ==)

DO_CMP_PPZW_H(sve_cmpeq_ppzw_h, uint16_t, uint64_t, ==)

DO_CMP_PPZW_S(sve_cmpeq_ppzw_s, uint32_t, uint64_t, ==)

DO_CMP_PPZW_B(sve_cmpeq_ppzw_b, int8_t,  uint64_t, ==)

DO_CMP_PPZW_H(sve_cmpeq_ppzw_h, int16_t, uint64_t, ==)

DO_CMP_PPZW_S(sve_cmpeq_ppzw_s, int32_t, uint64_t, ==)



DO_CMP_PPZW_B(sve_cmpne_ppzw_b, uint8_t,  uint64_t, !=)

DO_CMP_PPZW_H(sve_cmpne_ppzw_h, uint16_t, uint64_t, !=)

DO_CMP_PPZW_S(sve_cmpne_ppzw_s, uint32_t, uint64_t, !=)

DO_CMP_PPZW_B(sve_cmpne_ppzw_b, int8_t,  uint64_t, !=)

DO_CMP_PPZW_H(sve_cmpne_ppzw_h, int16_t, uint64_t, !=)

DO_CMP_PPZW_S(sve_cmpne_ppzw_s, int32_t, uint64_t, !=)



DO_CMP_PPZW_B(sve_cmpgt_ppzw_b, int8_t,   int64_t, >)

DO_CMP_PPZW_H(sve_cmpgt_ppzw_h, int16_t,  int64_t, >)