Commit ddb45afb authored by Peter Maydell's avatar Peter Maydell
Browse files

contrib/elf2dmp: Build download.o with CURL_CFLAGS



contrib/elf2dmp has a source file which uses curl/curl.h;
although we link the final executable with CURL_LIBS, we
forgot to build this source file with CURL_CFLAGS, so if
the curl header is in a place that's not already on the
system include path then it will fail to build.

Add a line specifying the cflags needed for download.o;
while we are here, bring the specification of the libs
into line with this, since using a per-object variable
setting is preferred over adding them to the final
executable link line.

Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Reviewed-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
Message-id: 20190719100955.17180-1-peter.maydell@linaro.org
parent a3e3b521
Loading
Loading
Loading
Loading
+0 −1
Original line number Diff line number Diff line
@@ -626,7 +626,6 @@ ifneq ($(EXESUF),)
qemu-ga: qemu-ga$(EXESUF) $(QGA_VSS_PROVIDER) $(QEMU_GA_MSI)
endif

elf2dmp$(EXESUF): LIBS += $(CURL_LIBS)
elf2dmp$(EXESUF): $(elf2dmp-obj-y)
	$(call LINK, $^)

+3 −0
Original line number Diff line number Diff line
elf2dmp-obj-y = main.o addrspace.o download.o pdb.o qemu_elf.o

download.o-cflags := $(CURL_CFLAGS)
download.o-libs   := $(CURL_LIBS)