Commit dd016265 authored by Alexander Bulekov's avatar Alexander Bulekov Committed by Thomas Huth
Browse files

fuzz: build without AddressSanitizer, by default 



We already have a nice --enable-sanitizers option to enable
AddressSanitizer. There is no reason to duplicate and force this
functionality in --enable-fuzzing. In the future, if more sanitizers are
added to --enable-sanitizers, it might be impossible to build with both
--enable-sanitizers and --enable-fuzzing, since not all sanitizers are
compatible with libFuzzer. In that case, we could enable ASAN with
--extra-cflags="-fsanitize=address"

Signed-off-by: default avatarAlexander Bulekov <alxndr@bu.edu>
Message-Id: <20200706195534.14962-2-alxndr@bu.edu>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: default avatarThomas Huth <thuth@redhat.com>
[thuth: Added missing $CFLAGS]
Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
parent 48eac101

configure

+5 −5
Original line number Diff line number Diff line
@@ -6337,7 +6337,7 @@ fi 
# checks for fuzzer

if test "$fuzzing" = "yes" ; then

  write_c_fuzzer_skeleton

  if compile_prog "$CPU_CFLAGS -Werror -fsanitize=address,fuzzer" ""; then

  if compile_prog "$CPU_CFLAGS -Werror -fsanitize=fuzzer" ""; then

      have_fuzzer=yes

  fi

fi
@@ -7893,11 +7893,11 @@ if test "$have_mlockall" = "yes" ; then 
fi

if test "$fuzzing" = "yes" ; then

  if test "$have_fuzzer" = "yes"; then

    FUZZ_LDFLAGS=" -fsanitize=address,fuzzer"

    FUZZ_CFLAGS=" -fsanitize=address,fuzzer"

    CFLAGS="$CFLAGS -fsanitize=address,fuzzer-no-link"

    FUZZ_LDFLAGS=" -fsanitize=fuzzer"

    FUZZ_CFLAGS=" -fsanitize=fuzzer"

    CFLAGS="$CFLAGS -fsanitize=fuzzer-no-link"

  else

    error_exit "Your compiler doesn't support -fsanitize=address,fuzzer"

    error_exit "Your compiler doesn't support -fsanitize=fuzzer"

    exit 1

  fi

fi