Commit dc89a180 authored by Thomas Huth's avatar Thomas Huth Committed by Peter Maydell
Browse files

hw/arm/allwinner-a10: Mark the allwinner-a10 device with user_creatable = false 



QEMU currently exits unexpectedly when the user accidentially
tries to do something like this:

$ aarch64-softmmu/qemu-system-aarch64 -S -M integratorcp -nographic
QEMU 2.9.93 monitor - type 'help' for more information
(qemu) device_add allwinner-a10
Unsupported NIC model: smc91c111

Exiting just due to a "device_add" should not happen. Looking closer
at the the realize and instance_init function of this device also
reveals that it is using serial_hds and nd_table directly there, so
this device is clearly not creatable by the user and should be marked
accordingly.

Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
Reviewed-by: default avatarEduardo Habkost <ehabkost@redhat.com>
Message-id: 1503416789-32080-1-git-send-email-thuth@redhat.com
Reviewed-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
parent 39d3d808

hw/arm/allwinner-a10.c

+2 −0
Original line number Diff line number Diff line
@@ -118,6 +118,8 @@ static void aw_a10_class_init(ObjectClass *oc, void *data) 
    DeviceClass *dc = DEVICE_CLASS(oc);



    dc->realize = aw_a10_realize;

    /* Reason: Uses serial_hds in realize and nd_table in instance_init */

    dc->user_creatable = false;

}



static const TypeInfo aw_a10_type_info = {

scripts/device-crash-test

+0 −1
Original line number Diff line number Diff line
@@ -187,7 +187,6 @@ ERROR_WHITELIST = [ 
    {'log':r"Device [\w.,-]+ can not be dynamically instantiated"},

    {'log':r"Platform Bus: Can not fit MMIO region of size "},

    # other more specific errors we will ignore:

    {'device':'allwinner-a10', 'log':"Unsupported NIC model:"},

    {'device':'.*-spapr-cpu-core', 'log':r"CPU core type should be"},

    {'log':r"MSI(-X)? is not supported by interrupt controller"},

    {'log':r"pxb-pcie? devices cannot reside on a PCIe? bus"},