Commit dc491fea authored by Marc-André Lureau's avatar Marc-André Lureau
Browse files

tests: fix qmp response leak 



Spotted by ASAN.

Signed-off-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
parent fc34059f

tests/libqos/usb.c

+1 −0
Original line number Diff line number Diff line
@@ -64,4 +64,5 @@ void usb_test_hotplug(const char *hcd_id, const int port, 
    g_assert(response);

    g_assert(qdict_haskey(response, "event"));

    g_assert(!strcmp(qdict_get_str(response, "event"), "DEVICE_DELETED"));

    QDECREF(response);

}

tests/postcopy-test.c

+1 −1
Original line number Diff line number Diff line
@@ -482,7 +482,7 @@ static void test_migrate(void) 
        usleep(10 * 1000);

    } while (dest_byte_a == dest_byte_b);



    qmp("{ 'execute' : 'stop'}");

    qmp_discard_response("{ 'execute' : 'stop'}");

    /* With it stopped, check nothing changes */

    qtest_memread(to, start_address, &dest_byte_c, 1);

    sleep(1);

tests/pvpanic-test.c

+1 −0
Original line number Diff line number Diff line
@@ -27,6 +27,7 @@ static void test_panic(void) 
    data = qdict_get_qdict(response, "data");

    g_assert(qdict_haskey(data, "action"));

    g_assert_cmpstr(qdict_get_str(data, "action"), ==, "pause");

    QDECREF(response);

}



int main(int argc, char **argv)

tests/test-filter-mirror.c

+1 −1
Original line number Diff line number Diff line
@@ -57,7 +57,7 @@ static void test_mirror(void) 
    };



    /* send a qmp command to guarantee that 'connected' is setting to true. */

    qmp("{ 'execute' : 'query-status'}");

    qmp_discard_response("{ 'execute' : 'query-status'}");

    ret = iov_send(send_sock[0], iov, 2, 0, sizeof(size) + sizeof(send_buf));

    g_assert_cmpint(ret, ==, sizeof(send_buf) + sizeof(size));

    close(send_sock[0]);

tests/test-filter-redirector.c

+2 −2
Original line number Diff line number Diff line
@@ -99,7 +99,7 @@ static void test_redirector_tx(void) 
    g_assert_cmpint(recv_sock, !=, -1);



    /* send a qmp command to guarantee that 'connected' is setting to true. */

    qmp("{ 'execute' : 'query-status'}");

    qmp_discard_response("{ 'execute' : 'query-status'}");



    struct iovec iov[] = {

        {
@@ -184,7 +184,7 @@ static void test_redirector_rx(void) 
    send_sock = unix_connect(sock_path1, NULL);

    g_assert_cmpint(send_sock, !=, -1);

    /* send a qmp command to guarantee that 'connected' is setting to true. */

    qmp("{ 'execute' : 'query-status'}");

    qmp_discard_response("{ 'execute' : 'query-status'}");



    ret = iov_send(send_sock, iov, 2, 0, sizeof(size) + sizeof(send_buf));

    g_assert_cmpint(ret, ==, sizeof(send_buf) + sizeof(size));