Commit dc0ae767 authored by Marcel Apfelbaum's avatar Marcel Apfelbaum Committed by Michael S. Tsirkin
Browse files

hw/pci: disable pci-bridge's shpc by default 



The shpc component is optional while  ACPI hotplug is used
for hot-plugging PCI devices into a PCI-PCI bridge.
Disabling the shpc by default will make slot 0 usable at boot time
and not only for hot-plug, without loosing any functionality.
Older machines will have shpc enabled for compatibility reasons.

Signed-off-by: default avatarMarcel Apfelbaum <marcel@redhat.com>
Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent e0b283e7

hw/pci-bridge/pci_bridge_dev.c

+1 −1
Original line number Diff line number Diff line
@@ -163,7 +163,7 @@ static Property pci_bridge_dev_properties[] = { 
    DEFINE_PROP_ON_OFF_AUTO(PCI_BRIDGE_DEV_PROP_MSI, PCIBridgeDev, msi,

                            ON_OFF_AUTO_AUTO),

    DEFINE_PROP_BIT(PCI_BRIDGE_DEV_PROP_SHPC, PCIBridgeDev, flags,

                    PCI_BRIDGE_DEV_F_SHPC_REQ, true),

                    PCI_BRIDGE_DEV_F_SHPC_REQ, false),

    DEFINE_PROP_END_OF_LIST(),

};

include/hw/compat.h

+4 −0
Original line number Diff line number Diff line
@@ -14,6 +14,10 @@ 
        .driver   = "pflash_cfi01",\

        .property = "old-multiple-chip-handling",\

        .value    = "on",\

    },{\

        .driver   = "pci-bridge",\

        .property = "shpc",\

        .value    = "on",\

    },



#define HW_COMPAT_2_7 \