Commit db575449 authored by Igor Mammedov's avatar Igor Mammedov Committed by Michael S. Tsirkin
Browse files

tests: acpi: make sure FADT is fetched only once 



Whole FADT is fetched as part of RSDT referenced tables in
fetch_rsdt_referenced_tables() albeit a bit later than when FADT
is partially parsed in fadt_fetch_facs_and_dsdt_ptrs().
However there is no reason for calling fetch_rsdt_referenced_tables()
so late, just move it right after we fetched RSDT and before
fadt_fetch_facs_and_dsdt_ptrs(). That way we can reuse whole FADT
fetched by fetch_rsdt_referenced_tables() and avoid duplicate
custom fields fetching in fadt_fetch_facs_and_dsdt_ptrs().

While at it rename fadt_fetch_facs_and_dsdt_ptrs() to
test_acpi_fadt_table(). The follow up patch will merge
fadt_fetch_facs_and_dsdt_ptrs() into test_acpi_rsdt_table(),
so that we would end up calling only test_acpi_FOO_table()
for consistency for tables that require special processing.

Signed-off-by: default avatarIgor Mammedov <imammedo@redhat.com>
Acked-by: default avatarThomas Huth <thuth@redhat.com>
Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent 81eb530d

tests/bios-tables-test.c

+8 −11
Original line number Diff line number Diff line
@@ -141,18 +141,15 @@ static void test_acpi_rsdt_table(test_data *data) 
    data->rsdt_tables_nr = tables_nr;

}



static void fadt_fetch_facs_and_dsdt_ptrs(test_data *data)

static void test_acpi_fadt_table(test_data *data)

{

    uint32_t addr;

    AcpiTableHeader hdr;

    /* FADT table is 1st */

    AcpiSdtTable *fadt = &g_array_index(data->tables, typeof(*fadt), 0);



    /* FADT table comes first */

    addr = le32_to_cpu(data->rsdt_tables_addr[0]);

    ACPI_READ_TABLE_HEADER(data->qts, &hdr, addr);

    ACPI_ASSERT_CMP(hdr.signature, "FACP");

    ACPI_ASSERT_CMP(fadt->header->signature, "FACP");



    ACPI_READ_FIELD(data->qts, data->facs_addr, addr);

    ACPI_READ_FIELD(data->qts, data->dsdt_addr, addr);

    memcpy(&data->facs_addr, fadt->aml + 36 /* FIRMWARE_CTRL */, 4);

    memcpy(&data->dsdt_addr, fadt->aml + 40 /* DSDT */, 4);

}



static void sanitize_fadt_ptrs(test_data *data)
@@ -628,10 +625,10 @@ static void test_acpi_one(const char *params, test_data *data) 
    test_acpi_rsdp_address(data);

    test_acpi_rsdp_table(data);

    test_acpi_rsdt_table(data);

    fadt_fetch_facs_and_dsdt_ptrs(data);

    fetch_rsdt_referenced_tables(data);

    test_acpi_fadt_table(data);

    test_acpi_facs_table(data);

    test_acpi_dsdt_table(data);

    fetch_rsdt_referenced_tables(data);



    sanitize_fadt_ptrs(data);