Commit db4df20d authored by Fam Zheng's avatar Fam Zheng Committed by Peter Maydell
Browse files

trace: Fix 'char **' compilation error in simple backend 



Currently, the generated function body will do "strlen(arg)" but the
argument could be 'char **' or 'char * const *'. Avoid that by excluding
such cases in is_string check.

Reported by patchew's "make docker-test-mingw@fedora".

Suggested-by: default avatarEric Blake <eblake@redhat.com>
Signed-off-by: default avatarFam Zheng <famz@redhat.com>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Message-id: 1477453806-21097-1-git-send-email-famz@redhat.com
Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
parent 835f3d24

scripts/tracetool/backend/simple.py

+2 −1
Original line number Diff line number Diff line
@@ -21,7 +21,8 @@ PUBLIC = True 


def is_string(arg):

    strtype = ('const char*', 'char*', 'const char *', 'char *')

    if arg.lstrip().startswith(strtype):

    arg_strip = arg.lstrip()

    if arg_strip.startswith(strtype) and arg_strip.count('*') == 1:

        return True

    else:

        return False