Commit dac23a6c authored by Marcel Apfelbaum's avatar Marcel Apfelbaum Committed by Michael S. Tsirkin
Browse files

tests/acpi-test: do not fail if iasl is broken 



There is an issue with iasl on big endian machines: It
cannot disassemble acpi tables taken from little endian
machines, so we cannot check the expected tables.

The acpi test will check if the expected aml files
can be disassembled, and will issue an warning not
failing the test on those machines until this
problem is solved by the acpica community.

Signed-off-by: default avatarMarcel Apfelbaum <marcel.a@redhat.com>
Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent af67ee92

tests/acpi-test.c

+15 −11
Original line number Diff line number Diff line
@@ -456,13 +456,12 @@ static bool load_asl(GArray *sdts, AcpiSdtTable *sdt) 
    /* pass 'out' and 'out_err' in order to be redirected */

    ret = g_spawn_command_line_sync(command_line->str, &out, &out_err, NULL, &error);

    g_assert_no_error(error);



    if (ret) {

        ret = g_file_get_contents(sdt->asl_file, (gchar **)&sdt->asl,

                                  &sdt->asl_len, &error);

        g_assert(ret);

        g_assert_no_error(error);

        g_assert(sdt->asl_len);

        ret = (sdt->asl_len > 0);

    }



    g_free(out);
@@ -560,6 +559,10 @@ static void test_acpi_asl(test_data *data) 
        g_assert(!err || exp_err);



        if (g_strcmp0(asl->str, exp_asl->str)) {

            if (exp_err) {

                fprintf(stderr,

                        "Warning! iasl couldn't parse the expected aml\n");

            } else {

                uint32_t signature = cpu_to_le32(exp_sdt->header.signature);

                sdt->tmp_files_retain = true;

                exp_sdt->tmp_files_retain = true;
@@ -570,6 +573,7 @@ static void test_acpi_asl(test_data *data) 
                        sdt->asl_file, sdt->aml_file,

                        exp_sdt->asl_file, exp_sdt->aml_file);

          }

        }

        g_string_free(asl, true);

        g_string_free(exp_asl, true);

    }