Commit da002526 authored by Markus Armbruster's avatar Markus Armbruster
Browse files

vl: Error messages need to go to stderr, fix some 



We print a few fatal error messages to stdout instead of stderr.
Reproducer:

    $ qemu-system-x86_64 -g 1024x768
    Option g not supported for this target
    $ qemu-system-x86_64 -g 1024x768 >/dev/null

Fix by printing them with error_report().  This also improves the messages.
The above one becomes

    qemu-system-x86_64: -g 1024x768: Option not supported for this target

Reported-by: Tobi {github.com/tobimensch}
Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
Message-Id: <1464683498-28779-1-git-send-email-armbru@redhat.com>
Reviewed-by: default avatarMarcel Apfelbaum <marcel@redhat.com>
parent 5edbd4e3

vl.c

+4 −4
Original line number Diff line number Diff line
@@ -3068,7 +3068,7 @@ int main(int argc, char **argv, char **envp) 


            popt = lookup_opt(argc, argv, &optarg, &optind);

            if (!(popt->arch_mask & arch_type)) {

                printf("Option %s not supported for this target\n", popt->name);

                error_report("Option not supported for this target");

                exit(1);

            }

            switch(popt->index) {
@@ -3846,21 +3846,21 @@ int main(int argc, char **argv, char **envp) 
                break;

            case QEMU_OPTION_xen_domid:

                if (!(xen_available())) {

                    printf("Option %s not supported for this target\n", popt->name);

                    error_report("Option not supported for this target");

                    exit(1);

                }

                xen_domid = atoi(optarg);

                break;

            case QEMU_OPTION_xen_create:

                if (!(xen_available())) {

                    printf("Option %s not supported for this target\n", popt->name);

                    error_report("Option not supported for this target");

                    exit(1);

                }

                xen_mode = XEN_CREATE;

                break;

            case QEMU_OPTION_xen_attach:

                if (!(xen_available())) {

                    printf("Option %s not supported for this target\n", popt->name);

                    error_report("Option not supported for this target");

                    exit(1);

                }

                xen_mode = XEN_ATTACH;