Commit d9f25280 authored by Peter Xu's avatar Peter Xu Committed by Markus Armbruster
Browse files

monitor: more comments on lock-free elements 



Add some explicit comments for both Readline and cpu_set/cpu_get helpers
that they do not need the mon_lock protection.

Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
Signed-off-by: default avatarPeter Xu <peterx@redhat.com>
Message-Id: <20180608035511.7439-4-peterx@redhat.com>
Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
parent 9409fc05

monitor.c

+10 −1
Original line number Diff line number Diff line
@@ -206,7 +206,15 @@ struct Monitor { 
    int suspend_cnt;            /* Needs to be accessed atomically */

    bool skip_flush;

    bool use_io_thr;



    /*

     * State used only in the thread "owning" the monitor.

     * If @use_io_thr, this is mon_global.mon_iothread.

     * Else, it's the main thread.

     * These members can be safely accessed without locks.

     */

    ReadLineState *rs;



    MonitorQMP qmp;

    gchar *mon_cpu_path;

    BlockCompletionFunc *password_completion_cb;
@@ -1311,7 +1319,7 @@ void qmp_qmp_capabilities(bool has_enable, QMPCapabilityList *enable, 
    cur_mon->qmp.commands = &qmp_commands;

}



/* set the current CPU defined by the user */

/* Set the current CPU defined by the user. Callers must hold BQL. */

int monitor_set_cpu(int cpu_index)

{

    CPUState *cpu;
@@ -1325,6 +1333,7 @@ int monitor_set_cpu(int cpu_index) 
    return 0;

}



/* Callers must hold BQL. */

static CPUState *mon_get_cpu_sync(bool synchronize)

{

    CPUState *cpu;