Commit d9e1f574 authored by Tomoki Sekiyama's avatar Tomoki Sekiyama Committed by Michael Roth
Browse files

qga: vss-win32: Fix interference with snapshot deletion by other VSS request 



When a VSS requester such as vshadow.exe or diskshadow.exe requests to
delete snapshots, qemu-ga VSS provider's DeleteSnapshots() is also called
and returns E_NOTIMPL, that makes the deletion fail.
To avoid this issue, return S_OK and set values that represent no snapshots
are deleted by qemu-ga VSS provider.

Signed-off-by: default avatarTomoki Sekiyama <tomoki.sekiyama@hds.com>
Reviewed-by: default avatarGal Hammer <ghammer@redhat.com>
Reviewed-by: default avatarYan Vugenfirer <yvugenfi@redhat.com>
Signed-off-by: default avatarMichael Roth <mdroth@linux.vnet.ibm.com>
parent ff8adbcf

qga/vss-win32/provider.cpp

+3 −1
Original line number Diff line number Diff line
@@ -278,7 +278,9 @@ STDMETHODIMP CQGAVssProvider::DeleteSnapshots( 
    VSS_ID SourceObjectId, VSS_OBJECT_TYPE eSourceObjectType,

    BOOL bForceDelete, LONG *plDeletedSnapshots, VSS_ID *pNondeletedSnapshotID)

{

    return E_NOTIMPL;

    *plDeletedSnapshots = 0;

    *pNondeletedSnapshotID = SourceObjectId;

    return S_OK;

}



STDMETHODIMP CQGAVssProvider::BeginPrepareSnapshot(