Commit d9b3ade5 authored by Xie Yongji's avatar Xie Yongji Committed by Michael S. Tsirkin
Browse files

libvhost-user: Zero memory allocated for VuVirtqInflightDesc 



Use a zero-initialized VuVirtqInflightDesc struct to avoid
that scan-build reports that vq->resubmit_list[0].counter may
be garbage value in vu_check_queue_inflights().

Fixes: 5f9ff1ef ("libvhost-user: Support tracking inflight I/O in
shared memory")
Reported-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: default avatarXie Yongji <xieyongji@baidu.com>
Message-Id: <20191119075759.4334-1-xieyongji@baidu.com>
Reviewed-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent 39e28210

contrib/libvhost-user/libvhost-user.c

+1 −1
Original line number Diff line number Diff line
@@ -992,7 +992,7 @@ vu_check_queue_inflights(VuDev *dev, VuVirtq *vq) 
    vq->shadow_avail_idx = vq->last_avail_idx = vq->inuse + vq->used_idx;



    if (vq->inuse) {

        vq->resubmit_list = malloc(sizeof(VuVirtqInflightDesc) * vq->inuse);

        vq->resubmit_list = calloc(vq->inuse, sizeof(VuVirtqInflightDesc));

        if (!vq->resubmit_list) {

            return -1;

        }