Commit d959f6cf authored by Janosch Frank's avatar Janosch Frank Committed by Christian Borntraeger
Browse files

s390x: sclp: fix error handling for oversize control blocks 



Requests over 4k are not a spec exception.

Signed-off-by: default avatarJanosch Frank <frankja@linux.ibm.com>
Reviewed-by: default avatarJason J. Herne <jjherne@linux.ibm.com>
Message-Id: <1569591203-15258-4-git-send-email-imbrenda@linux.ibm.com>
Acked-by: default avatarDavid Hildenbrand <david@redhat.com>
Signed-off-by: default avatarChristian Borntraeger <borntraeger@de.ibm.com>
parent 6f6c9333

hw/s390x/sclp.c

+1 −2
Original line number Diff line number Diff line
@@ -213,8 +213,7 @@ int sclp_service_call(CPUS390XState *env, uint64_t sccb, uint32_t code) 
    cpu_physical_memory_read(sccb, &work_sccb, sccb_len);



    /* Valid sccb sizes */

    if (be16_to_cpu(work_sccb.h.length) < sizeof(SCCBHeader) ||

        be16_to_cpu(work_sccb.h.length) > SCCB_SIZE) {

    if (be16_to_cpu(work_sccb.h.length) < sizeof(SCCBHeader)) {

        r = -PGM_SPECIFICATION;

        goto out;

    }