Commit d86b4672 authored by Damien Hedde's avatar Damien Hedde Committed by Alex Bennée
Browse files

gdbstub: do not split gdb_monitor_write payload 



Since we can now send packets of arbitrary length:
simplify gdb_monitor_write() and send the whole payload
in one packet.

Suggested-by: default avatarLuc Michel <luc.michel@greensocs.com>
Signed-off-by: default avatarDamien Hedde <damien.hedde@greensocs.com>
Signed-off-by: default avatarAlex Bennée <alex.bennee@linaro.org>
Reviewed-by: default avatarRichard Henderson <richard.henderson@linaro.org>
Message-Id: <20191211160514.58373-3-damien.hedde@greensocs.com>
Message-Id: <20200316172155.971-28-alex.bennee@linaro.org>
parent d116e813

gdbstub.c

+3 −20
Original line number Diff line number Diff line
@@ -3200,28 +3200,11 @@ static void gdb_chr_event(void *opaque, QEMUChrEvent event) 
    }

}



static void gdb_monitor_output(const char *msg, int len)

{

    g_autoptr(GString) buf = g_string_new("O");

    memtohex(buf, (uint8_t *)msg, len);

    put_packet(buf->str);

}



static int gdb_monitor_write(Chardev *chr, const uint8_t *buf, int len)

{

    const char *p = (const char *)buf;

    int max_sz;



    max_sz = (MAX_PACKET_LENGTH / 2) + 1;

    for (;;) {

        if (len <= max_sz) {

            gdb_monitor_output(p, len);

            break;

        }

        gdb_monitor_output(p, max_sz);

        p += max_sz;

        len -= max_sz;

    }

    g_autoptr(GString) hex_buf = g_string_new("O");

    memtohex(hex_buf, buf, len);

    put_packet(hex_buf->str);

    return len;

}