Commit d7ec83e6 authored by Avi Kivity's avatar Avi Kivity
Browse files

memory: don't pass ->readable attribute to cpu_register_physical_memory_log 



It can be derived from the MemoryRegion itself (which is why it is not
used there).

Signed-off-by: default avatarAvi Kivity <avi@redhat.com>
Reviewed-by: default avatarRichard Henderson <rth@twiddle.net>
parent 7a8499e8

exec-obsolete.h

+1 −1
Original line number Diff line number Diff line
@@ -37,7 +37,7 @@ void cpu_unregister_io_memory(int table_address); 


struct MemoryRegionSection;

void cpu_register_physical_memory_log(struct MemoryRegionSection *section,

                                      bool readable, bool readonly);

                                      bool readonly);



void qemu_register_coalesced_mmio(target_phys_addr_t addr, ram_addr_t size);

void qemu_unregister_coalesced_mmio(target_phys_addr_t addr, ram_addr_t size);

exec.c

+1 −1
Original line number Diff line number Diff line
@@ -2529,7 +2529,7 @@ static subpage_t *subpage_init (target_phys_addr_t base, ram_addr_t *phys, 
   before calculating this offset.  This should not be a problem unless

   the low bits of start_addr and region_offset differ.  */

void cpu_register_physical_memory_log(MemoryRegionSection *section,

                                      bool readable, bool readonly)

                                      bool readonly)

{

    target_phys_addr_t start_addr = section->offset_within_address_space;

    ram_addr_t size = section->size;

memory.c

+2 −2
Original line number Diff line number Diff line
@@ -346,7 +346,7 @@ static void as_memory_range_add(AddressSpace *as, FlatRange *fr) 
        .readonly = fr->readonly,

    };



    cpu_register_physical_memory_log(&section, fr->readable, fr->readonly);

    cpu_register_physical_memory_log(&section, fr->readonly);

}



static void as_memory_range_del(AddressSpace *as, FlatRange *fr)
@@ -359,7 +359,7 @@ static void as_memory_range_del(AddressSpace *as, FlatRange *fr) 
        .readonly = fr->readonly,

    };



    cpu_register_physical_memory_log(&section, true, false);

    cpu_register_physical_memory_log(&section, false);

}



static void as_memory_log_start(AddressSpace *as, FlatRange *fr)