Commit d789c845 authored by Laszlo Ersek's avatar Laszlo Ersek Committed by Peter Maydell
Browse files

fw_cfg_mem: flip ctl_mem_ops and data_mem_ops to DEVICE_BIG_ENDIAN 



The standalone selector port (fw_cfg_ctl_mem_ops) is only used by big
endian guests to date (*), hence this change doesn't regress them. Paolo
and Alex have suggested / requested an explicit DEVICE_BIG_ENDIAN setting
here, for clarity.

(*) git grep -l fw_cfg_init_mem

    hw/nvram/fw_cfg.c
    hw/ppc/mac_newworld.c
    hw/ppc/mac_oldworld.c
    hw/sparc/sun4m.c
    include/hw/nvram/fw_cfg.h

The standalone data port (fw_cfg_data_mem_ops) has max_access_size 1 (for
now), hence changing its endianness doesn't change behavior for existing
guest code.

Signed-off-by: default avatarLaszlo Ersek <lersek@redhat.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Message-id: 1419250305-31062-5-git-send-email-pbonzini@redhat.com
Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
parent 86099db3

hw/nvram/fw_cfg.c

+2 −2
Original line number Diff line number Diff line
@@ -332,14 +332,14 @@ static bool fw_cfg_comb_valid(void *opaque, hwaddr addr, 


static const MemoryRegionOps fw_cfg_ctl_mem_ops = {

    .write = fw_cfg_ctl_mem_write,

    .endianness = DEVICE_NATIVE_ENDIAN,

    .endianness = DEVICE_BIG_ENDIAN,

    .valid.accepts = fw_cfg_ctl_mem_valid,

};



static const MemoryRegionOps fw_cfg_data_mem_ops = {

    .read = fw_cfg_data_mem_read,

    .write = fw_cfg_data_mem_write,

    .endianness = DEVICE_NATIVE_ENDIAN,

    .endianness = DEVICE_BIG_ENDIAN,

    .valid = {

        .min_access_size = 1,

        .max_access_size = 1,