Commit d718b14b authored by Pavel Dovgalyuk's avatar Pavel Dovgalyuk Committed by Paolo Bonzini
Browse files

replay: improve interrupt handling 



This patch improves interrupt handling in record/replay mode.
Now "interrupt" event is saved only when cc->cpu_exec_interrupt returns true.
This patch also adds missing return to cpu_exec_interrupt function.

Signed-off-by: default avatarPavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
Message-Id: <20170124071708.4572.64023.stgit@PASHA-ISP>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 8094532b

cpu-exec.c

+1 −1
Original line number Diff line number Diff line
@@ -508,8 +508,8 @@ static inline void cpu_handle_interrupt(CPUState *cpu, 
           True when it is, and we should restart on a new TB,

           and via longjmp via cpu_loop_exit.  */

        else {

            replay_interrupt();

            if (cc->cpu_exec_interrupt(cpu, interrupt_request)) {

                replay_interrupt();

                *last_tb = NULL;

            }

            /* The target hook may have updated the 'cpu->interrupt_request';

target/i386/seg_helper.c

+1 −0
Original line number Diff line number Diff line
@@ -1331,6 +1331,7 @@ bool x86_cpu_exec_interrupt(CPUState *cs, int interrupt_request) 
#endif

    if (interrupt_request & CPU_INTERRUPT_SIPI) {

        do_cpu_sipi(cpu);

        ret = true;

    } else if (env->hflags2 & HF2_GIF_MASK) {

        if ((interrupt_request & CPU_INTERRUPT_SMI) &&

            !(env->hflags & HF_SMM_MASK)) {