Commit d6e58090 authored by Ulrich Obergfell's avatar Ulrich Obergfell Committed by Anthony Liguori
Browse files

severe memory leak caused by broken palette_destroy() function 

The following commit breaks the code of the function palette_destroy().

http://git.kernel.org/?p=virt/kvm/qemu-kvm.git;a=commit;h=e31e3694afef58ba191cbcc6875ec243e5971268



The broken code causes a severe memory leak of 'VncPalette' structures
because it never frees anything:

     70 void palette_destroy(VncPalette *palette)
     71 {
     72     if (palette == NULL) {
     73         qemu_free(palette);
     74     }
     75 }

Version 2 of the patch calls qemu_free() unconditionally.

Signed-off-by: default avatarUlrich Obergfell <uobergfe@redhat.com>
Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
parent 05175535

ui/vnc-palette.c

+1 −3
Original line number Diff line number Diff line
@@ -69,10 +69,8 @@ void palette_init(VncPalette *palette, size_t max, int bpp) 


void palette_destroy(VncPalette *palette)

{

    if (palette == NULL) {

    qemu_free(palette);

}

}



int palette_put(VncPalette *palette, uint32_t color)

{