Commit d6919e4c authored by Alexander Bulekov's avatar Alexander Bulekov Committed by Stefan Hajnoczi
Browse files

main: keep rcu_atfork callback enabled for qtest 



The qtest-based fuzzer makes use of forking to reset-state between
tests. Keep the callback enabled, so the call_rcu thread gets created
within the child process.

Signed-off-by: default avatarAlexander Bulekov <alxndr@bu.edu>
Reviewed-by: default avatarDarren Kenny <darren.kenny@oracle.com>
Acked-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
Message-id: 20200220041118.23264-15-alxndr@bu.edu
Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
parent a028edea

softmmu/vl.c

+11 −1
Original line number Diff line number Diff line
@@ -3782,7 +3782,17 @@ void qemu_init(int argc, char **argv, char **envp) 
    set_memory_options(&ram_slots, &maxram_size, machine_class);



    os_daemonize();



    /*

     * If QTest is enabled, keep the rcu_atfork enabled, since system processes

     * may be forked testing purposes (e.g. fork-server based fuzzing) The fork

     * should happen before a signle cpu instruction is executed, to prevent

     * deadlocks. See commit 73c6e40, rcu: "completely disable pthread_atfork

     * callbacks as soon as possible"

     */

    if (!qtest_enabled()) {

        rcu_disable_atfork();

    }



    if (pid_file && !qemu_write_pidfile(pid_file, &err)) {

        error_reportf_err(err, "cannot create PID file: ");