Commit d6322252 authored by Cédric Le Goater's avatar Cédric Le Goater Committed by David Gibson
Browse files

spapr/rtas: fix reboot of a a SMP TCG guest 



Just like for hot unplug CPUs, when a guest is rebooted, the secondary
CPUs can be awaken by the decrementer and start entering SLOF at the
same time the boot CPU is.

To be safe, let's disable on the secondaries all the exceptions which
can cause an exit while the CPU is in power-saving mode.

Based on previous work from Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>

Signed-off-by: default avatarCédric Le Goater <clg@kaod.org>
Reviewed-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
parent 9a94ee5b

hw/ppc/spapr_cpu_core.c

+8 −0
Original line number Diff line number Diff line
@@ -26,6 +26,7 @@ static void spapr_cpu_reset(void *opaque) 
    PowerPCCPU *cpu = opaque;

    CPUState *cs = CPU(cpu);

    CPUPPCState *env = &cpu->env;

    PowerPCCPUClass *pcc = POWERPC_CPU_GET_CLASS(cpu);



    cpu_reset(cs);
@@ -35,6 +36,13 @@ static void spapr_cpu_reset(void *opaque) 
    cs->halted = 1;



    env->spr[SPR_HIOR] = 0;



    /* Disable Power-saving mode Exit Cause exceptions for the CPU.

     * This can cause issues when rebooting the guest if a secondary

     * is awaken */

    if (cs != first_cpu) {

        env->spr[SPR_LPCR] &= ~pcc->lpcr_pm;

    }

}



static void spapr_cpu_destroy(PowerPCCPU *cpu)