Commit d44bb860 authored by Amos Kong's avatar Amos Kong Committed by Anthony Liguori
Browse files

virtio-rng: add check of period 



If period is assigned to 0, limit timer will expire immediately.
It causes a qemu warning:

"main-loop: WARNING: I/O thread spun for 1000 iterations"

This limit is meaningless. This patch forbids to assign 0 to period.

Reviewed-by: default avatarAmit Shah <amit.shah@redhat.com>
Signed-off-by: default avatarAmos Kong <akong@redhat.com>
Message-id: 1385031203-23790-1-git-send-email-akong@redhat.com
Signed-off-by: default avatarAnthony Liguori <aliguori@amazon.com>
parent 376827d4

hw/virtio/virtio-rng.c

+6 −0
Original line number Diff line number Diff line
@@ -139,6 +139,12 @@ static int virtio_rng_device_init(VirtIODevice *vdev) 
    VirtIORNG *vrng = VIRTIO_RNG(vdev);

    Error *local_err = NULL;



    if (!vrng->conf.period_ms > 0) {

        qerror_report(QERR_INVALID_PARAMETER_VALUE, "period",

                      "a positive number");

        return -1;

    }



    if (vrng->conf.rng == NULL) {

        vrng->conf.default_backend = RNG_RANDOM(object_new(TYPE_RNG_RANDOM));