Commit d38253cf authored by Stefan Hajnoczi's avatar Stefan Hajnoczi
Browse files

block/nvme: drop tautologous assertion 



nvme_process_completion() explicitly checks cid so the assertion that
follows is always true:

  if (cid == 0 || cid > NVME_QUEUE_SIZE) {
      ...
      continue;
  }
  assert(cid <= NVME_QUEUE_SIZE);

Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: default avatarSergio Lopez <slp@redhat.com>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20200617132201.1832152-3-stefanha@redhat.com
Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
parent 2446e0e2

block/nvme.c

+0 −1
Original line number Diff line number Diff line
@@ -336,7 +336,6 @@ static bool nvme_process_completion(BDRVNVMeState *s, NVMeQueuePair *q) 
                    cid);

            continue;

        }

        assert(cid <= NVME_QUEUE_SIZE);

        trace_nvme_complete_command(s, q->index, cid);

        preq = &q->reqs[cid - 1];

        req = *preq;