Commit d281084d authored by Alex Williamson's avatar Alex Williamson
Browse files

vfio-pci: Don't use kvm_irqchip_in_kernel 



kvm_irqchip_in_kernel() has an architecture specific meaning, so
we shouldn't be using it to determine whether to enabled KVM INTx
bypass.  kvm_irqfds_enabled() seems most appropriate.  Also use this
to protect our other call to kvm_check_extension() as that explodes
when KVM isn't enabled.

Signed-off-by: default avatarAlex Williamson <alex.williamson@redhat.com>
Cc: qemu-stable@nongnu.org
parent 1c97e303

hw/vfio_pci.c

+3 −2
Original line number Diff line number Diff line
@@ -275,7 +275,7 @@ static void vfio_enable_intx_kvm(VFIODevice *vdev) 
    int ret, argsz;

    int32_t *pfd;



    if (!kvm_irqchip_in_kernel() ||

    if (!kvm_irqfds_enabled() ||

        vdev->intx.route.mode != PCI_INTX_ENABLED ||

        !kvm_check_extension(kvm_state, KVM_CAP_IRQFD_RESAMPLE)) {

        return;
@@ -438,7 +438,8 @@ static int vfio_enable_intx(VFIODevice *vdev) 
     * Only conditional to avoid generating error messages on platforms

     * where we won't actually use the result anyway.

     */

    if (kvm_check_extension(kvm_state, KVM_CAP_IRQFD_RESAMPLE)) {

    if (kvm_irqfds_enabled() &&

        kvm_check_extension(kvm_state, KVM_CAP_IRQFD_RESAMPLE)) {

        vdev->intx.route = pci_device_route_intx_to_irq(&vdev->pdev,

                                                        vdev->intx.pin);

    }