Commit d1cc1533 authored Sep 11, 2019 by Libo Zhou Committed by Aleksandar Markovic Sep 12, 2019

target/mips: gdbstub: Revert commit 8e0b373f

Multiple reports from users were received regarding failures of
packet 'g' communication with gdb for some MIPS configurations.
It was found out (by bisecting) that the problematic commit is
8e0b373f. Revert that commit until a better solution is developed.

Suggested-by: Aleksandar Markovic <amarkovic@wavecomp.com>
Signed-off-by: Libo Zhou <zhlb29@foxmail.com>
Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
Reviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com>
Message-Id: <1568207966-25202-1-git-send-email-aleksandar.markovic@rt-rk.com>

parent 6626286e

target/mips/gdbstub.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -38,7 +38,7 @@ int mips_cpu_gdb_read_register(CPUState cs, uint8_t mem_buf, int n)
		return gdb_get_regl(mem_buf, (int32_t)env->active_fpu.fcr0);
		default:
		if (env->CP0_Status & (1 << CP0St_FR)) {
		return gdb_get_reg64(mem_buf,
		return gdb_get_regl(mem_buf,
		env->active_fpu.fpr[n - 38].d);
		} else {
		return gdb_get_regl(mem_buf,
		@@ -99,7 +99,6 @@ int mips_cpu_gdb_write_register(CPUState cs, uint8_t mem_buf, int n)
		break;
		default:
		if (env->CP0_Status & (1 << CP0St_FR)) {
		uint64_t tmp = ldq_p(mem_buf);
		env->active_fpu.fpr[n - 38].d = tmp;
		} else {
		env->active_fpu.fpr[n - 38].w[FP_ENDIAN_IDX] = tmp;