Commit d1a88c96 authored by Scott Feldman's avatar Scott Feldman Committed by Stefan Hajnoczi
Browse files

rocker: fix misplaced break statement 



Premature break in switch case block.  This particular case (group L2 rewrite)
will be used for L2 LAG and L3 ECMP support, neither of which are enabled in
the guest driver at this time, but are under development.

Signed-off-by: default avatarScott Feldman <sfeldma@gmail.com>
Reported-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Message-id: 1435746792-41278-2-git-send-email-sfeldma@gmail.com
Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
parent 66851f64

hw/net/rocker/rocker_of_dpa.c

+1 −1
Original line number Diff line number Diff line
@@ -2525,7 +2525,6 @@ static void of_dpa_group_fill(void *key, void *value, void *user_data) 
            ngroup->has_set_vlan_id = true;

            ngroup->set_vlan_id = ntohs(group->l2_rewrite.vlan_id);

        }

        break;

        if (memcmp(group->l2_rewrite.src_mac.a, zero_mac.a, ETH_ALEN)) {

            ngroup->has_set_eth_src = true;

            ngroup->set_eth_src =
@@ -2536,6 +2535,7 @@ static void of_dpa_group_fill(void *key, void *value, void *user_data) 
            ngroup->set_eth_dst =

                qemu_mac_strdup_printf(group->l2_rewrite.dst_mac.a);

        }

        break;

    case ROCKER_OF_DPA_GROUP_TYPE_L2_FLOOD:

    case ROCKER_OF_DPA_GROUP_TYPE_L2_MCAST:

        ngroup->has_vlan_id = true;