Commit d09c4a47 authored by Marc-André Lureau's avatar Marc-André Lureau Committed by Paolo Bonzini
Browse files

chardev: fix backend events regression with mux chardev 



Kirill noticied that on recent versions on QEMU he was not able to
trigger SysRq to invoke debug capabilites of Linux Kernel.  He tracked
it down to qemu_chr_be_event() ignoring CHR_EVENT_BREAK due s->be
being NULL. The bug was introduced in 2.8, commit a4afa548 ("char:
move front end handlers in CharBackend"). Since the commit, the
qemu_chr_be_event() failed to deliver CHR_EVENT_BREAK due to
qemu_chr_fe_init() does not set s->be in case of mux.

Let's fix this by teaching mux to send an event to the frontend with
the focus.

Reported-by: default avatarKirill A. Shutemov <kirill.shutemov@linux.intel.com>
Signed-off-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
Fixes: a4afa548 ("char: move front end handlers in CharBackend")
Message-Id: <20171103152824.21948-2-marcandre.lureau@redhat.com>
Tested-by: default avatarKirill A. Shutemov <kirill.shutemov@linux.intel.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 5a22ab71

chardev/char-mux.c

+10 −0
Original line number Diff line number Diff line
@@ -123,6 +123,15 @@ static void mux_chr_send_event(MuxChardev *d, int mux_nr, int event) 
    }

}



static void mux_chr_be_event(Chardev *chr, int event)

{

    MuxChardev *d = MUX_CHARDEV(chr);



    if (d->focus != -1) {

        mux_chr_send_event(d, d->focus, event);

    }

}



static int mux_proc_byte(Chardev *chr, MuxChardev *d, int ch)

{

    if (d->term_got_escape) {
@@ -346,6 +355,7 @@ static void char_mux_class_init(ObjectClass *oc, void *data) 
    cc->chr_write = mux_chr_write;

    cc->chr_accept_input = mux_chr_accept_input;

    cc->chr_add_watch = mux_chr_add_watch;

    cc->chr_be_event = mux_chr_be_event;

}



static const TypeInfo char_mux_type_info = {

chardev/char.c

+12 −6
Original line number Diff line number Diff line
@@ -43,10 +43,19 @@ static Object *get_chardevs_root(void) 
    return container_get(object_get_root(), "/chardevs");

}



void qemu_chr_be_event(Chardev *s, int event)

static void chr_be_event(Chardev *s, int event)

{

    CharBackend *be = s->be;



    if (!be || !be->chr_event) {

        return;

    }



    be->chr_event(be->opaque, event);

}



void qemu_chr_be_event(Chardev *s, int event)

{

    /* Keep track if the char device is open */

    switch (event) {

        case CHR_EVENT_OPENED:
@@ -57,11 +66,7 @@ void qemu_chr_be_event(Chardev *s, int event) 
            break;

    }



    if (!be || !be->chr_event) {

        return;

    }



    be->chr_event(be->opaque, event);

    CHARDEV_GET_CLASS(s)->chr_be_event(s, event);

}



/* Not reporting errors from writing to logfile, as logs are
@@ -244,6 +249,7 @@ static void char_class_init(ObjectClass *oc, void *data) 
    ChardevClass *cc = CHARDEV_CLASS(oc);



    cc->chr_write = null_chr_write;

    cc->chr_be_event = chr_be_event;

}



static void char_finalize(Object *obj)

include/chardev/char.h

+1 −0
Original line number Diff line number Diff line
@@ -248,6 +248,7 @@ typedef struct ChardevClass { 
    void (*chr_accept_input)(Chardev *chr);

    void (*chr_set_echo)(Chardev *chr, bool echo);

    void (*chr_set_fe_open)(Chardev *chr, int fe_open);

    void (*chr_be_event)(Chardev *s, int event);

} ChardevClass;



Chardev *qemu_chardev_new(const char *id, const char *typename,