Commit d047cfa7 authored by Vladimir Sementsov-Ogievskiy's avatar Vladimir Sementsov-Ogievskiy Committed by Kevin Wolf
Browse files

iotests: test shutdown when bitmap is exported through NBD



Test shutdown when bitmap is exported through NBD and active client
exists. The previous patch fixes a crash, provoked by this scenario.

Signed-off-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Tested-by: default avatarEric Blake <eblake@redhat.com>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Message-Id: <20200714162234.13113-3-vsementsov@virtuozzo.com>
Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
parent 453cc6be
Loading
Loading
Loading
Loading

tests/qemu-iotests/299

0 → 100644
+65 −0
Original line number Diff line number Diff line
#!/usr/bin/env python3
#
# Test shutdown when bitmap is exported through NBD server
#
# Copyright (c) 2020 Virtuozzo International GmbH.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program.  If not, see <http://www.gnu.org/licenses/>.
#

import iotests

# The test is unrelated to formats, restrict it to qcow2 to avoid extra runs
iotests.script_initialize(
    supported_fmts=['qcow2'],
)

nbd_sock = iotests.file_path('nbd.sock', base_dir=iotests.sock_dir)
nbd_uri = 'nbd+unix:///disk?socket=' + nbd_sock
size = 1024 * 1024

vm = iotests.VM()
vm.launch()

vm.qmp_log('blockdev-add', **{
    'node-name': 'disk',
    'driver': 'null-co',
    'size': 1024 * 1024,
})

vm.qmp_log('block-dirty-bitmap-add', **{
    'node': 'disk',
    'name': 'bitmap0'
})

vm.qmp_log('nbd-server-start', **{
    'addr': {
        'type': 'unix',
        'data': {'path': nbd_sock}
    }
}, filters=[iotests.filter_qmp_testfiles])

vm.qmp_log('nbd-server-add', **{
    'device': 'disk',
    'writable': True,
    'bitmap': 'bitmap0'
})

p = iotests.QemuIoInteractive('-f', 'raw', nbd_uri)
# wait for connection and check it:
iotests.log(p.cmd('read 0 512').rstrip(), filters=[iotests.filter_qemu_io])

vm.shutdown()

p.close()
+10 −0
Original line number Diff line number Diff line
{"execute": "blockdev-add", "arguments": {"driver": "null-co", "node-name": "disk", "size": 1048576}}
{"return": {}}
{"execute": "block-dirty-bitmap-add", "arguments": {"name": "bitmap0", "node": "disk"}}
{"return": {}}
{"execute": "nbd-server-start", "arguments": {"addr": {"data": {"path": "SOCK_DIR/PID-nbd.sock"}, "type": "unix"}}}
{"return": {}}
{"execute": "nbd-server-add", "arguments": {"bitmap": "bitmap0", "device": "disk", "writable": true}}
{"return": {}}
read 512/512 bytes at offset 0
512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
+1 −0
Original line number Diff line number Diff line
@@ -306,4 +306,5 @@
295 rw
296 rw
297 meta
299 auto quick
301 backing quick