Commit d013283a authored by Juan Quintela's avatar Juan Quintela Committed by Dr. David Alan Gilbert
Browse files

migration: Fix migrate_set_parameter 



Otherwise we are setting err twice, what is wrong and causes an abort.

Signed-off-by: default avatarJuan Quintela <quintela@redhat.com>
Message-Id: <20190403114958.3705-2-quintela@redhat.com>
Reviewed-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
parent c6e5bafb

hmp.c

+4 −2
Original line number Diff line number Diff line
@@ -1825,8 +1825,10 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict) 
    case MIGRATION_PARAMETER_XBZRLE_CACHE_SIZE:

        p->has_xbzrle_cache_size = true;

        visit_type_size(v, param, &cache_size, &err);

        if (err || cache_size > INT64_MAX

            || (size_t)cache_size != cache_size) {

        if (err) {

            break;

        }

        if (cache_size > INT64_MAX || (size_t)cache_size != cache_size) {

            error_setg(&err, "Invalid size %s", valuestr);

            break;

        }